Skip to content
This repository has been archived by the owner on Nov 23, 2024. It is now read-only.

Support yml extension and remove mandatory file pattern #155

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support yml extension and remove mandatory file pattern #155

wants to merge 2 commits into from

Conversation

d-rk
Copy link

@d-rk d-rk commented May 6, 2020

Hi,

the restrictions on the secret names are very counter-intuitive. e.g.:

helm secrets dec secrets.yml
Decrypting secrets.yml
sops metadata not found
Error: plugin "secrets" exited with error

this fails, because yml is not supported. Additionally, the secret gets deleted with this :(

Currently the secret has to conform the following regex:
^secrets(.[^.]+)*.yaml$

This pull request removes the restriction completely and allows any *.yml / *.yaml to be processed.
Instead of relying on the filename the content of the file is checked to verify that it is a sops encrypted file.

Resolves #124, resolves #128

@jkroepke jkroepke mentioned this pull request May 7, 2020
Merged
@Morriz
Copy link

Morriz commented Sep 22, 2020

any progress here?

@d-rk
Copy link
Author

d-rk commented Sep 22, 2020

Morriz
Morriz suggested changes Sep 23, 2020
View reviewed changes
Copy link

@Morriz Morriz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to cleanup the mixing of tabs and spaces, and only use two spaces (seeing that no specs are given in the repo).

@Morriz
Copy link

Morriz commented Sep 23, 2020

I can do a more thorough review later and see if I have rights to approve and if that is enough to merge ;p

@d-rk
Copy link
Author

d-rk commented Oct 14, 2020

@Morriz the mixing of tabs and spaces was not introduced by this PR. This is also present on the master branch.
If this is fixed on master I can rebase the PR, but I don't think fixing this belongs into this PR.
Besides that, after roughly half a year has passed I'm not willing to but more time into this before knowing that this has a chance of being merged.

@tyrken tyrken mentioned this pull request Oct 28, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Morriz Morriz Morriz requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support secrets[._-]*.yaml doesnt decode secret file
2 participants
@d-rk @Morriz